netdev - Re: [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de2ef417-ddf0-516f-4b11-ce834764497c@broadcom.com>
Date:   Mon, 16 Mar 2020 19:21:11 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Doug Berger <opendmb@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC
 reset"



On 3/16/2020 2:44 PM, Doug Berger wrote:
> This reverts commit 3a55402c93877d291b0a612d25edb03d1b4b93ac.
> 
> This is not a good solution when connecting to an external switch
> that may not support the isolation of the TXC signal resulting in
> output driver contention on the pin.
> 
> A different solution is necessary.
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Did you want this to be tagged with:

Fixes: 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC reset")

so as to make it more explicit how the two commits relate to each other?

Thanks!
--
Florian