netdev - Re: [PATCH ethtool] ethtool: Add support for Low Latency Reed Solomon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200317082310.GE10043@unicorn.suse.cz>
Date:   Tue, 17 Mar 2020 09:23:10 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     "John W. Linville" <linville@...driver.com>,
        netdev@...r.kernel.org, Moshe Shemesh <moshe@...lanox.com>,
        Aya Levin <ayal@...lanox.com>
Subject: Re: [PATCH ethtool] ethtool: Add support for Low Latency Reed Solomon

On Tue, Mar 17, 2020 at 10:06:26AM +0200, Tariq Toukan wrote:
> On 3/13/2020 9:28 PM, John W. Linville wrote:
> > On Thu, Mar 12, 2020 at 05:12:03PM +0200, Tariq Toukan wrote:
> > > From: Aya Levin <ayal@...lanox.com>
> > > 
> > > Introduce a new FEC mode LL-RS: Low Latency Reed Solomon, update print
> > > and initialization functions accordingly. In addition, update related
> > > man page.
> > > 
> > > Signed-off-by: Aya Levin <ayal@...lanox.com>
> > > Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> > > ---
> > >   ethtool-copy.h |  3 +++
> > >   ethtool.8.in   |  5 +++--
> > >   ethtool.c      | 12 +++++++++++-
> > >   3 files changed, 17 insertions(+), 3 deletions(-)
> > 
> > Hey...
> > 
> > Thanks for the patch! Unfortunately for you, I just merged "[PATCH
> > ethtool v3 01/25] move UAPI header copies to a separate directory"
> > from Michal Kubecek <mkubecek@...e.cz>, and that patch did this:
> > 
> >   ethtool-copy.h => uapi/linux/ethtool.h       | 0
> >   rename ethtool-copy.h => uapi/linux/ethtool.h (100%)
> > 
> > Could you please rework your patch against the current kernel.org tree?
> 
> Hi John,
> Sure, we'll rework and respin.

When you do, please update also link_modes[] array in netlink/settings.c
I'll have to think of some long term solution (like kernel providing
this information) but that is something for the future development.

Michal