netdev - Re: [PATCH net-next v4] xen networking: add basic XDP support for xen-netfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f75365c7-a3ca-cf12-b2fc-e48652071795@suse.com>
Date:   Wed, 18 Mar 2020 12:16:25 +0100
From:   Jürgen Groß <jgross@...e.com>
To:     Denis Kirjanov <kda@...ux-powerpc.org>, netdev@...r.kernel.org
Cc:     ilias.apalodimas@...aro.org, wei.liu@...nel.org, paul@....org
Subject: Re: [PATCH net-next v4] xen networking: add basic XDP support for
 xen-netfront

On 16.03.20 14:09, Denis Kirjanov wrote:
> The patch adds a basic XDP processing to xen-netfront driver.
> 
> We ran an XDP program for an RX response received from netback
> driver. Also we request xen-netback to adjust data offset for
> bpf_xdp_adjust_head() header space for custom headers.

This is in no way a "verbose patch descriprion".

I'm missing:

- Why are you doing this. "Add XDP support" is not enough, for such
   a change I'd like to see some performance numbers to get an idea
   of the improvement to expect, or which additional functionality
   for the user is available.

- A short description for me as a Xen maintainer with only basic
   networking know-how, what XDP programs are about (a link to some
   more detailed doc is enough, of course) and how the interface
   is working (especially for switching between XDP mode and normal
   SKB processing).

- A proper description of the netfront/netback communication when
   enabling or disabling XDP mode (who is doing what, is silencing
   of the virtual adapter required, ...).

- Reasoning why the suggested changes of frontend and backend state
   are no problem for special cases like hot-remove of an interface or
   live migration or suspend of the guest.

Finally I'd like to ask you to split up the patch into a netfront and
a netback one.


Juergen