netdev - Re: [PATCH net-next 09/11] devlink: Add new enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Mar 2020 13:15:21 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pavan Chebbi <pavan.chebbi@...adcom.com>
Cc:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>,
        davem@...emloft.net, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH net-next 09/11] devlink: Add new enable_ecn generic
 device param

On Wed, 18 Mar 2020 10:56:52 +0530 Pavan Chebbi wrote:
> On Tue, Mar 17, 2020 at 11:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Tue, 17 Mar 2020 20:47:24 +0530 Vasundhara Volam wrote:  
> > > From: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > >
> > > Add new device parameter to enable/disable handling of Explicit
> > > Congestion Notification(ECN) in the device.
> > >
> > > This patch also addresses comments from Jiri Pirko, to update the
> > > devlink-info.rst documentation.
> > >
> > > Cc: Jiri Pirko <jiri@...lanox.com>
> > > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > > Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> > > Signed-off-by: Michael Chan <michael.chan@...adcom.com>  
> >
> > Nacked-by: Jakub Kicinski <kuba@...nel.org>
> >
> > We've been over this multiple times. Devlink is not for configuring
> > forwarding features. Use qdisc offload.  
> 
> This is just a config option like enable_sriov and enable_roce.
> This will only enable the capability in the device and not configure any rules.

Not what the documentation added by the patch says. But I'm sure the
reality^W documentation can be bent as needed.

If you really "just enable the capability like SR-IOV", please come
back with this patch once you implement an API to make use of such
capability.