netdev - Re: [RFC PATCH 00/28]: Accurate ECN for TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200318.162958.1146893420208387579.davem@davemloft.net>
Date:   Wed, 18 Mar 2020 16:29:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ilpo.jarvinen@...sinki.fi
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, ncardwell@...gle.com,
        eric.dumazet@...il.com, olivier.tilmans@...ia-bell-labs.com
Subject: Re: [RFC PATCH 00/28]: Accurate ECN for TCP

From: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Date: Wed, 18 Mar 2020 11:43:04 +0200

> Comments would be highly appreciated.

Two coding style comments which you should audit your entire submission
for:

1) Please order local variables in reverse christmas tree ordering (longest
   to shortest long)

2) Please do not use the inline keyword in foo.c files, let the compiler
   decide.

Thank you.