netdev - Re: [PATCH net] net/sched: act_ct: Fix leak of ct zone template on replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200318.163816.1292858106592359997.davem@davemloft.net>
Date:   Wed, 18 Mar 2020 16:38:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     saeedm@...lanox.com, ozsh@...lanox.com,
        jakub.kicinski@...ronome.com, vladbu@...lanox.com,
        netdev@...r.kernel.org, jiri@...lanox.com, roid@...lanox.com
Subject: Re: [PATCH net] net/sched: act_ct: Fix leak of ct zone template on
 replace

From: Paul Blakey <paulb@...lanox.com>
Date: Wed, 18 Mar 2020 12:50:33 +0200

> Currently, on replace, the previous action instance params
> is swapped with a newly allocated params. The old params is
> only freed (via kfree_rcu), without releasing the allocated
> ct zone template related to it.
> 
> Call tcf_ct_params_free (via call_rcu) for the old params,
> so it will release it.
> 
> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
> Signed-off-by: Paul Blakey <paulb@...lanox.com>

Applied and queued up for -stable.