netdev - Re: [PATCH net-next 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbfe6e031a0b70c5143f759469154a0714af0dd5.camel@mellanox.com>
Date:   Wed, 18 Mar 2020 04:05:05 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "wenxu@...oud.cn" <wenxu@...oud.cn>,
        Paul Blakey <paulb@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft_cb
 support

On Tue, 2020-03-17 at 20:58 -0700, Saeed Mahameed wrote:
> On Mon, 2020-03-16 at 11:14 +0800, wenxu wrote:
> > On 12/18/2019 3:54 AM, Saeed Mahameed wrote:
> > > On Wed, 2019-12-11 at 10:41 +0800, wenxu wrote:
> > > > On 12/10/2019 7:44 PM, Paul Blakey wrote:
> > > > > On 12/10/2019 12:08 PM, wenxu@...oud.cn wrote:
> > > > > > From: wenxu <wenxu@...oud.cn>
> > > > > > 
> > > > > > Add mlx5e_rep_indr_setup_ft_cb to support indr block setup
> > > > > > in FT mode.
> > > > > > 
> > > > > > Signed-off-by: wenxu <wenxu@...oud.cn>
> > > > > > ---
> > > [...]
> > > 
> > > > > +cc Saeed
> > > > > 
> > > > > 
> > > > > This looks good to me, but it should be on top of a patch
> > > > > that
> > > > > will 
> > > > > actual allows the indirect BIND if the nft
> > > > > 
> > > > > table device is a tunnel device. Is that upstream? If so
> > > > > which
> > > > > patch?
> > > > > 
> > > > > 
> > > > > Currently (5.5.0-rc1+), nft_register_flowtable_net_hooks
> > > > > calls 
> > > > > nf_flow_table_offload_setup which will see
> > > > > 
> > > > > that the tunnel device doesn't have ndo_setup_tc and return 
> > > > > -EOPNOTSUPPORTED.
> > > > The related patch  http://patchwork.ozlabs.org/patch/1206935/
> > > > 
> > > > is waiting for upstream
> > > > 
> > > The netfilter patch is still under-review, once accepted i will
> > > apply
> > > this series.
> > > 
> > > Thanks,
> > > Saeed.
> > > 
> > Hi Saeed,
> > 
> > 
> > Sorry for so long time to update. The netfilter patch is already
> > accepted.  This series is also
> > 
> > not out of date and can apply to net-next.  If you feel ok  please
> > apply it thanks.
> > 
> > 
> > The netfilter patch:
> > 
> > http://patchwork.ozlabs.org/patch/1242815/
> > 
> > BR
> > 
> > wenxu
> > 
> 
> Applied to net-next-mlx5,  doing some build testing now, and will
> make
> this run in regression for a couple of days until my next pull
> request
> to net-next.
> 

hmmm, i was too optimistic, patches got blocked by CI, apparently some
changes in mlx5 eswitch API are causing the following failure, most
likely due to the introduction of eswitch_chains API.

05:57:47 make -s -j 96 CC=/usr/llvm/bin/clang
drivers/net/ethernet/mellanox/mlx5/core/
05:58:14 error: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:752:8:
error: implicit declaration of function 'mlx5_eswitch_prios_supported'
[-Werror,-Wimplicit-function-declaration]
05:58:14 error: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:752:8:
note: did you mean 'mlx5_esw_chains_prios_supported'?
05:58:14 


Please rebase and re-test, I can help you with more details if you
need.

Thanks,
Saeed.

> Thanks,
> saeed.