netdev - Re: [PATCH] rtl8xxxu: Fix sparse warning: cast from restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb942467-fc43-114f-3fd4-f38db90d505b@trained-monkey.org>
Date:   Thu, 19 Mar 2020 10:19:29 -0400
From:   Jes Sorensen <jes@...ined-monkey.org>
To:     Chris Chiu <chiu@...lessm.com>, kvalo@...eaurora.org,
        davem@...emloft.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...lessm.com,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] rtl8xxxu: Fix sparse warning: cast from restricted __le16

On 3/19/20 2:43 AM, Chris Chiu wrote:
> Fix the warning reported by sparse as:
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4819:17: sparse: sparse: cast from restricted __le16
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4892:17: sparse: sparse: cast from restricted __le16
> 
> Signed-off-by: Chris Chiu <chiu@...lessm.com>
> Reported-by: kbuild test robot <lkp@...el.com>

Acked-by: Jes Sorensen <jes@...ined-monkey.org>


> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 54a1a4ea107b..daa6ce14c68b 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -4816,8 +4816,8 @@ rtl8xxxu_fill_txdesc_v1(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
>  		rate = tx_rate->hw_value;
>  
>  	if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX)
> -		dev_info(dev, "%s: TX rate: %d, pkt size %d\n",
> -			 __func__, rate, cpu_to_le16(tx_desc->pkt_size));
> +		dev_info(dev, "%s: TX rate: %d, pkt size %u\n",
> +			 __func__, rate, le16_to_cpu(tx_desc->pkt_size));
>  
>  	seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl));
>  
> @@ -4889,8 +4889,8 @@ rtl8xxxu_fill_txdesc_v2(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
>  		rate = tx_rate->hw_value;
>  
>  	if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX)
> -		dev_info(dev, "%s: TX rate: %d, pkt size %d\n",
> -			 __func__, rate, cpu_to_le16(tx_desc40->pkt_size));
> +		dev_info(dev, "%s: TX rate: %d, pkt size %u\n",
> +			 __func__, rate, le16_to_cpu(tx_desc40->pkt_size));
>  
>  	seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl));
>  
>