netdev - Re: [PATCH net-next 1/2] net: rename flow_action_hw_stats_types* -> flow_action_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Mar 2020 15:29:51 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kernel-team@...com,
        ecree@...arflare.com, pablo@...filter.org
Subject: Re: [PATCH net-next 1/2] net: rename flow_action_hw_stats_types* ->
 flow_action_hw_stats*

Wed, Mar 18, 2020 at 08:42:20PM CET, kuba@...nel.org wrote:
>On Wed, 18 Mar 2020 07:33:56 +0100 Jiri Pirko wrote:
>> >diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>> >index efd8d47f6997..1e30b0d44b61 100644
>> >--- a/include/net/flow_offload.h
>> >+++ b/include/net/flow_offload.h
>> >@@ -163,19 +163,17 @@ enum flow_action_mangle_base {
>> > };
>> > 
>> > enum flow_action_hw_stats_type_bit {  
>> 
>> You should rename this enum.
>> 
>> 
>> >-	FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE_BIT,
>> >-	FLOW_ACTION_HW_STATS_TYPE_DELAYED_BIT,
>> >+	FLOW_ACTION_HW_STATS_IMMEDIATE_BIT,
>> >+	FLOW_ACTION_HW_STATS_DELAYED_BIT,
>> > };
>> > 
>> > enum flow_action_hw_stats_type {  
>> 
>> And this enum too.
>> Also, while at it I think you should also rename the uapi and rest of
>> the occurances to make things consistent.
>
>Do you want me to rename the variables and struct members, too?

Well, I think it would be for the best, so the names are consistent.


>
>I thought in there the _type is fine, given how they are used.