netdev - Re: [PATCH net-next 6/6] netfilter: nf_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Mar 2020 20:37:36 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Paul Blakey <paulb@...lanox.com>
Cc:     Edward Cree <ecree@...arflare.com>,
        netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, ozsh@...lanox.com, majd@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [PATCH net-next 6/6] netfilter: nf_flow_table: hardware offload
 support

On Thu, Mar 19, 2020 at 06:47:07PM +0200, Paul Blakey wrote:
> 
> On 19/03/2020 17:57, Edward Cree wrote:
[...]
> > <snip>
> >> +static int nf_flow_rule_match(struct nf_flow_match *match,
> >> +			      const struct flow_offload_tuple *tuple)
> >> +{
> >> +	struct nf_flow_key *mask = &match->mask;
> >> +	struct nf_flow_key *key = &match->key;
> >> +
> >> +	NF_FLOW_DISSECTOR(match, FLOW_DISSECTOR_KEY_CONTROL, control);
> >> +	NF_FLOW_DISSECTOR(match, FLOW_DISSECTOR_KEY_BASIC, basic);
> >> +	NF_FLOW_DISSECTOR(match, FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4);
> >> +	NF_FLOW_DISSECTOR(match, FLOW_DISSECTOR_KEY_TCP, tcp);
> >> +	NF_FLOW_DISSECTOR(match, FLOW_DISSECTOR_KEY_PORTS, tp);
> >> +
> >> +	switch (tuple->l3proto) {
> >> +	case AF_INET:
> >> +		key->control.addr_type = FLOW_DISSECTOR_KEY_IPV4_ADDRS;
> >>
> > Is it intentional that mask->control.addr_type never gets set?
>
> It should be set.

I'd be glad to take a patch for this into nf.git

Thanks.