netdev - Re: [RFC PATCH 00/28]: Accurate ECN for TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.2003192222320.5256@whs-18.cs.helsinki.fi>
Date:   Thu, 19 Mar 2020 22:25:23 +0200 (EET)
From:   "Ilpo Järvinen" <ilpo.jarvinen@...helsinki.fi>
To:     David Miller <davem@...emloft.net>
cc:     Netdev <netdev@...r.kernel.org>, Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Olivier Tilmans <olivier.tilmans@...ia-bell-labs.com>
Subject: Re: [RFC PATCH 00/28]: Accurate ECN for TCP

On Wed, 18 Mar 2020, David Miller wrote:

> From: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> Date: Wed, 18 Mar 2020 11:43:04 +0200
> 
> > Comments would be highly appreciated.
> 
> Two coding style comments which you should audit your entire submission
> for:
> 
> 1) Please order local variables in reverse christmas tree ordering (longest
>    to shortest long)

Does this apply also to the usual struct tcp_sock *tp = tcp_sk(sk); line
or can it be put first if there are some dependencies on it?

> 2) Please do not use the inline keyword in foo.c files, let the compiler
>    decide.

Thanks. I'll do those (I certainly removed some other bits I moved from
header to .c but missed a few it seems). 

-- 
 i.