netdev - Re: [PATCH net-next 0/5] mlxsw: Offload TC action skbedit priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200319152412.088acba3@kicinski-fedora-PC1C0HJN>
Date:   Thu, 19 Mar 2020 15:24:12 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, petrm@...lanox.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 0/5] mlxsw: Offload TC action skbedit priority

On Thu, 19 Mar 2020 15:47:19 +0200 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> Petr says:
> 
> The TC action "skbedit priority P" has the effect of assigning skbprio of P
> to SKBs that it's applied on. In HW datapath of a switch, the corresponding
> action is assignment of internal switch priority. Spectrum switches allow
> setting of packet priority based on an ACL action, which is good match for
> the skbedit priority gadget. This patchset therefore implements offloading
> of this action to the Spectrum ACL engine.
> 
> After a bit of refactoring in patch #1, patch #2 extends the skbedit action
> to support offloading of "priority" subcommand.
> 
> On mlxsw side, in patch #3, the QOS_ACTION flexible action is added, with
> fields necessary for priority adjustment. In patch #4, "skbedit priority"
> is connected to that action.
> 
> Patch #5 implements a new forwarding selftest, suitable for both SW- and
> HW-datapath testing.

FWIW:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>