netdev - Re: [PATCH net-next] net: mvmdio: fix driver probe on missing irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de28dd392987d666f9ad4a0c94e71fc0a686d8d6.camel@alliedtelesis.co.nz>
Date:   Thu, 19 Mar 2020 04:27:56 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     "marek.behun@....cz" <marek.behun@....cz>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: mvmdio: fix driver probe on missing irq

On Thu, 2020-03-19 at 05:21 +0100, Marek Behun wrote:
> On Thu, 19 Mar 2020 02:00:57 +0000
> Chris Packham <Chris.Packham@...iedtelesis.co.nz> wrote:
> 
> > Hi Marek,
> > 
> > On Thu, 2020-03-19 at 02:29 +0100, Marek Behún wrote:
> > > Commit e1f550dc44a4 made the use of platform_get_irq_optional, which can
> > > return -ENXIO when interrupt is missing. Handle this as non-error,
> > > otherwise the driver won't probe.  
> > 
> > This has already been fixed in net/master by reverting e1f550dc44a4 and
> > replacing it with fa2632f74e57bbc869c8ad37751a11b6147a3acc.
> 
> :( It isn't in net-next. I've spent like an hour debugging it :-D

I can only offer my humble apologies and promise to do better next
time. I did test the first minimally correct change, but clearly
stuffed up on v2.