netdev - Re: [PATCH] mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Mar 2020 10:55:08 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_cnt: Fix 64-bit division in
 mlxsw_sp_counter_resources_register

Fri, Mar 20, 2020 at 03:16:38AM CET, natechancellor@...il.com wrote:
>When building arm32 allyesconfig:
>
>ld.lld: error: undefined symbol: __aeabi_uldivmod
>>>> referenced by spectrum_cnt.c
>>>>               net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a
>>>> did you mean: __aeabi_uidivmod
>>>> defined in: arch/arm/lib/lib.a(lib1funcs.o)
>
>pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms
>do not error.
>
>Fixes: ab8c4cc60420 ("mlxsw: spectrum_cnt: Move config validation along with resource register")
>Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks!