netdev - Re: [PATCH net-next] liquidio: remove set but not used variable 's'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200320131429.GH4650@kadam>
Date:   Fri, 20 Mar 2020 06:14:29 -0700 (PDT)
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Leon Romanovsky <leonro@...lanox.com>
Cc:     YueHaibing <yuehaibing@...wei.com>,
        Derek Chickles <dchickles@...vell.com>,
        "David S . Miller" <davem@...emloft.net>,
        Satanand Burla <sburla@...vell.com>,
        Felix Manlunas <fmanlunas@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH net-next] liquidio: remove set but not used variable 's'

On Thu, Mar 19, 2020 at 02:10:35PM +0200, Leon Romanovsky wrote:
> On Thu, Mar 19, 2020 at 12:07:43PM +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_chip_specific_setup':
> > drivers/net/ethernet/cavium/liquidio/lio_main.c:1378:8: warning:
> >  variable 's' set but not used [-Wunused-but-set-variable]
> >
> > It's not used since commit b6334be64d6f ("net/liquidio: Delete driver version assignment")
> >
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> 
> I'm sorry for missing this warning.
> 

The warning is not enabled by default.

regards,
dan carpenter