netdev - Re: [PATCH 2/2] io_uring: make sure accept honor rlimit nofile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <885293a8-7d2c-2957-ae72-9d834bcad0ed@kernel.dk>
Date:   Fri, 20 Mar 2020 08:48:07 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     David Miller <davem@...emloft.net>
Cc:     io-uring@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] io_uring: make sure accept honor rlimit nofile

On 3/19/20 10:43 PM, David Miller wrote:
> From: Jens Axboe <axboe@...nel.dk>
> Date: Thu, 19 Mar 2020 20:22:16 -0600
> 
>> Just like commit 21ec2da35ce3, this fixes the fact that
>> IORING_OP_ACCEPT ends up using get_unused_fd_flags(), which checks
>> current->signal->rlim[] for limits.
>>
>> Add an extra argument to __sys_accept4_file() that allows us to pass
>> in the proper nofile limit, and grab it at request prep time.
>>
>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> 
> Acked-by: David S. Miller <davem@...emloft.net>

Thanks, added to both.

-- 
Jens Axboe