netdev - Re: [PATCH bpf-next 1/2] bpf: tcp: Fix unused function warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71161d44-da82-b4ae-ee9e-8291d9d03021@iogearbox.net>
Date:   Fri, 20 Mar 2020 16:01:32 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, YueHaibing <yuehaibing@...wei.com>,
        lmb@...udflare.com, jakub@...udflare.com, john.fastabend@...il.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, andrii.nakryiko@...il.com
Subject: Re: [PATCH bpf-next 1/2] bpf: tcp: Fix unused function warnings

On 3/20/20 5:21 AM, Yonghong Song wrote:
> On 3/19/20 7:34 PM, YueHaibing wrote:
>> If BPF_STREAM_PARSER is not set, gcc warns:
>>
>> net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function]
>>
>> Moves the unused functions into the #ifdef
> 
> Maybe explicit "into the #ifdef CONFIG_BPF_STREAM_PARSER"?
> 
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Fixes: f747632b608f ("bpf: sockmap: Move generic sockmap hooks from BPF TCP")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> Reviewed-by: Lorenz Bauer <lmb@...udflare.com>
>> Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>
> 
> Acked-by: Yonghong Song <yhs@...com>

Both applied and addressed feedback from Yonghong, thanks!