netdev - Re: [PATCH bpf-next] bpf: tcp: Fix unused function warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f27ae22a-e5e4-2873-1e00-bb59979e92ff@huawei.com>
Date:   Fri, 20 Mar 2020 10:33:12 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
CC:     <lmb@...udflare.com>, <daniel@...earbox.net>,
        <john.fastabend@...il.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: tcp: Fix unused function warnings

On 2020/3/20 1:00, Jakub Sitnicki wrote:
> On Thu, Mar 19, 2020 at 01:46 PM CET, YueHaibing wrote:
>> If BPF_STREAM_PARSER is not set, gcc warns:
>>
>> net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function]
>>
>> Moves the unused functions into the #ifdef
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
> 
> In addition to this fix, looks like tcp_bpf_recvmsg can be static and
> also conditional on CONFIG_BPF_STREAM_PARSER.

Thanks, will do this in next version.

> 
> Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>
> 
> .
>