netdev - Re: [PATCH net-next v2] net: bridge: vlan: include stats in dumps if requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200319.202206.1844889598253272050.davem@davemloft.net>
Date:   Thu, 19 Mar 2020 20:22:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next v2] net: bridge: vlan: include stats in dumps
 if requested

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Thu, 19 Mar 2020 12:14:14 +0200

> This patch adds support for vlan stats to be included when dumping vlan
> information. We have to dump them only when explicitly requested (thus the
> flag below) because that disables the vlan range compression and will make
> the dump significantly larger. In order to request the stats to be
> included we add a new dump attribute called BRIDGE_VLANDB_DUMP_FLAGS which
> can affect dumps with the following first flag:
>   - BRIDGE_VLANDB_DUMPF_STATS
> The stats are intentionally nested and put into separate attributes to make
> it easier for extending later since we plan to add per-vlan mcast stats,
> drop stats and possibly STP stats. This is the last missing piece from the
> new vlan API which makes the dumped vlan information complete.
> 
> A dump request which should include stats looks like:
>  [BRIDGE_VLANDB_DUMP_FLAGS] |= BRIDGE_VLANDB_DUMPF_STATS
> 
> A vlandb entry attribute with stats looks like:
>  [BRIDGE_VLANDB_ENTRY] = {
>      [BRIDGE_VLANDB_ENTRY_STATS] = {
>          [BRIDGE_VLANDB_STATS_RX_BYTES]
>          [BRIDGE_VLANDB_STATS_RX_PACKETS]
>          ...
>      }
>  }
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> v2: Use a separate dump attribute for the flags instead of a reserved
>     field to avoid uapi breakage as noted by DaveM.
>     Rebased and retested on the latest net-next.

Thanks for reworking UAPI.

Applied, thanks.