netdev - Re: [PATCH net] cxgb4: fix Txq restart check during backpressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200319.213050.1103025966630815592.davem@davemloft.net>
Date:   Thu, 19 Mar 2020 21:30:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, vishal@...lsio.com,
        dt@...lsio.com
Subject: Re: [PATCH net] cxgb4: fix Txq restart check during backpressure

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Thu, 19 Mar 2020 23:08:10 +0530

> Driver reclaims descriptors in much smaller batches, even if hardware
> indicates more to reclaim, during backpressure. So, fix the check to
> restart the Txq during backpressure, by looking at how many
> descriptors hardware had indicated to reclaim, and not on how many
> descriptors that driver had actually reclaimed. Once the Txq is
> restarted, driver will reclaim even more descriptors when Tx path
> is entered again.
> 
> Fixes: d429005fdf2c ("cxgb4/cxgb4vf: Add support for SGE doorbell queue timer")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied, thanks.