netdev - Re: [RFC PATCH 00/28]: Accurate ECN for TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200319.213832.2258629564733373153.davem@davemloft.net>
Date:   Thu, 19 Mar 2020 21:38:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ilpo.jarvinen@...helsinki.fi
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, ncardwell@...gle.com,
        eric.dumazet@...il.com, olivier.tilmans@...ia-bell-labs.com
Subject: Re: [RFC PATCH 00/28]: Accurate ECN for TCP

From: "Ilpo Järvinen" <ilpo.jarvinen@...helsinki.fi>
Date: Thu, 19 Mar 2020 22:25:23 +0200 (EET)

> On Wed, 18 Mar 2020, David Miller wrote:
> 
>> From: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
>> Date: Wed, 18 Mar 2020 11:43:04 +0200
>> 
>> > Comments would be highly appreciated.
>> 
>> Two coding style comments which you should audit your entire submission
>> for:
>> 
>> 1) Please order local variables in reverse christmas tree ordering (longest
>>    to shortest long)
> 
> Does this apply also to the usual struct tcp_sock *tp = tcp_sk(sk); line
> or can it be put first if there are some dependencies on it?

Yes, please.  Put the assignment into the code lines if necessary.