netdev - Re: [PATCH net-next] net/mlx5e: Fix actions_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35fcb57643c0522b051318e75b106100422fb1dc.camel@mellanox.com>
Date:   Sat, 21 Mar 2020 02:43:08 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        Paul Blakey <paulb@...lanox.com>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Roi Dayan <roid@...lanox.com>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Oz Shlomo <ozsh@...lanox.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5e: Fix actions_match_supported() return

On Fri, 2020-03-20 at 16:23 +0300, Dan Carpenter wrote:
> The actions_match_supported() function returns a bool, true for
> success
> and false for failure.  This error path is returning a negative which
> is cast to true but it should return false.
> 
> Fixes: 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index 044891a03be3..e5de7d2bac2b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -3058,7 +3058,7 @@ static bool actions_match_supported(struct
> mlx5e_priv *priv,
>  			 */
>  			NL_SET_ERR_MSG_MOD(extack,
>  					   "Can't offload mirroring
> with action ct");
> -			return -EOPNOTSUPP;
> +			return false;
>  		}
>  	} else {
>  		actions = flow->nic_attr->action;

applied to net-next-mlx5 

Thanks,
Saeed.