netdev - Re: [PATCH net-next v2 0/7] introduce read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Mar 2020 17:50:14 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     f.fainelli@...il.com, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, allison@...utok.net, corbet@....net,
        alexios.zavras@...el.com, broonie@...nel.org, tglx@...utronix.de,
        mchehab+samsung@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/7] introduce read_poll_timeout

On Fri, Mar 20, 2020 at 09:34:24PM +0800, Dejin Zheng wrote:
> This patch sets is introduce read_poll_timeout macro, it is an extension
> of readx_poll_timeout macro. the accessor function op just supports only
> one parameter in the readx_poll_timeout macro, but this macro can
> supports multiple variable parameters for it. so functions like
> phy_read(struct phy_device *phydev, u32 regnum) and
> phy_read_mmd(struct phy_device *phydev, int devad, u32 regnum) can
> use this poll timeout framework.
> 
> the first patch introduce read_poll_timeout macro, and the second patch
> redefined readx_poll_timeout macro by read_poll_timeout(), and the other
> patches are examples using read_poll_timeout macro.

You missed lan87xx_read_status(), tja11xx_check(), and mv3310_reset().

If you convert all these, your diffstat might look better.

   Andrew