netdev - Re: [PATCH net] hsr: fix general protection fault in hsr_addr_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Mar 2020 19:50:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] hsr: fix general protection fault in
 hsr_addr_is_self()

From: Taehee Yoo <ap420073@...il.com>
Date: Sat, 21 Mar 2020 06:46:50 +0000

> The port->hsr is used in the hsr_handle_frame(), which is a
> callback of rx_handler.
> hsr master and slaves are initialized in hsr_add_port().
> This function initializes several pointers, which includes port->hsr after
> registering rx_handler.
> So, in the rx_handler routine, un-initialized pointer would be used.
> In order to fix this, pointers should be initialized before
> registering rx_handler.
> 
> Test commands:
...
> Reported-by: syzbot+fcf5dd39282ceb27108d@...kaller.appspotmail.com
> Fixes: c5a759117210 ("net/hsr: Use list_head (and rcu) instead of array for slave devices.")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for -stable, thank you.