netdev - Re: [PATCH net] net: bcmgenet: always enable status blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200321.201846.2033521113132339001.davem@davemloft.net>
Date:   Sat, 21 Mar 2020 20:18:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     opendmb@...il.com
Cc:     f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: always enable status blocks

From: Doug Berger <opendmb@...il.com>
Date: Tue, 17 Mar 2020 17:05:36 -0700

> The hardware offloading of the NETIF_F_HW_CSUM and NETIF_F_RXCSUM
> features requires the use of Transmit Status Blocks before transmit
> frame data and Receive Status Blocks before receive frame data to
> carry the checksum information.
> 
> Unfortunately, these status blocks are currently only enabled when
> the NETIF_F_HW_CSUM feature is enabled. As a result NETIF_F_RXCSUM
> will not actually be offloaded to the hardware unless both it and
> NETIF_F_HW_CSUM are enabled. Fortunately, that is the default
> configuration.
> 
> This commit addresses this issue by always enabling the use of
> status blocks on both transmit and receive frames. Further, it
> replaces the use of a dedicated flag within the driver private
> data structure with direct use of the netdev features flags.
> 
> Fixes: 810155397890 ("net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUM")
> Signed-off-by: Doug Berger <opendmb@...il.com>

Applied, thank you.