netdev - Re: [PATCH net] selftests/net: add definition for SOL_DCCP to fix compilation errors for old libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200321.202332.1124475628215113570.davem@davemloft.net>
Date:   Sat, 21 Mar 2020 20:23:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alan.maguire@...cle.com
Cc:     kuba@...nel.org, shuah@...nel.org, netdev@...r.kernel.org,
        posk@...gle.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] selftests/net: add definition for SOL_DCCP to fix
 compilation errors for old libc

From: Alan Maguire <alan.maguire@...cle.com>
Date: Wed, 18 Mar 2020 18:53:21 +0000

> Many systems build/test up-to-date kernels with older libcs, and
> an older glibc (2.17) lacks the definition of SOL_DCCP in
> /usr/include/bits/socket.h (it was added in the 4.6 timeframe).
> 
> Adding the definition to the test program avoids a compilation
> failure that gets in the way of building tools/testing/selftests/net.
> The test itself will work once the definition is added; either
> skipping due to DCCP not being configured in the kernel under test
> or passing, so there are no other more up-to-date glibc dependencies
> here it seems beyond that missing definition.
> 
> Fixes: 11fb60d1089f ("selftests: net: reuseport_addr_any: add DCCP")
> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>

Applied.