netdev - Re: [PATCH net-next v4 8/9] net: phy: smsc: use phy_read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200322153942.GQ11481@lunn.ch>
Date:   Sun, 22 Mar 2020 16:39:42 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     f.fainelli@...il.com, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        broonie@...nel.org, alexios.zavras@...el.com, tglx@...utronix.de,
        mchehab+samsung@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 8/9] net: phy: smsc: use
 phy_read_poll_timeout() to simplify the code

> @@ -125,15 +123,11 @@ static int lan87xx_read_status(struct phy_device *phydev)
>  			return rc;
>  
>  		/* Wait max 640 ms to detect energy */
> -		for (i = 0; i < 64; i++) {
> -			/* Sleep to allow link test pulses to be sent */
> -			msleep(10);

Another example where you should add an msleep() before
phy_read_poll_timeout().

	Andrew