netdev - RE: [PATCH net-next] Remove DST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3316a66b025a4823887e4c34c6e2fe7e@AcuMS.aculab.com>
Date:   Mon, 23 Mar 2020 16:58:41 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'David Ahern' <dsahern@...il.com>,
        Network Development <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] Remove DST_HOST

From: David Ahern
> Sent: 23 March 2020 16:15
> On 3/23/20 8:31 AM, David Laight wrote:
> > Previous changes to the IP routing code have removed all the
> > tests for the DS_HOST route flag.
> > Remove the flags and all the code that sets it.
> >
> > Signed-off-by: David Laight <david.laight@...lab.com>
> > ---
> > AFAICT the DST_HOST flag in route table entries hasn't been
> > looked at since v4.2-rc1.
> 
> even back in 4.14 it was set and only checked in one spot -
> fib6_commit_metrics.
> 
> >
> > A quick search failed to find the commit that removed the
> > tests for it from ipv6/route.c
> > I suspect other changes got added on top.
> 
> been on my to-do list to verify it was no longer needed. thanks for sending.

I was trying to unravel that code a bit to find out whether
raw sockets with 'hdrincl' looked up the correct route (ie
the one from the sendto 'destination address' rather than
anything in the supplied ip header).
The temporary 'dst' structures are expensive'.
If nothing else they can be freed immediately rather than
after rcu.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)