netdev - Re: [PATCH net v2] net: cbs: Fix software cbs to consider packet sending time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tv2edfnq.fsf@intel.com>
Date:   Mon, 23 Mar 2020 12:39:37 -0700
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Zh-yuan Ye <ye.zh-yuan@...ionext.com>, netdev@...r.kernel.org
Cc:     okamoto.satoru@...ionext.com, kojima.masahisa@...ionext.com,
        Zh-yuan Ye <ye.zh-yuan@...ionext.com>
Subject: Re: [PATCH net v2] net: cbs: Fix software cbs to consider packet sending time

Hi,

Zh-yuan Ye <ye.zh-yuan@...ionext.com> writes:

> Currently the software CBS does not consider the packet sending time
> when depleting the credits. It caused the throughput to be
> Idleslope[kbps] * (Port transmit rate[kbps] / |Sendslope[kbps]|) where
> Idleslope * (Port transmit rate / (Idleslope + |Sendslope|)) = Idleslope
> is expected. In order to fix the issue above, this patch takes the time
> when the packet sending completes into account by moving the anchor time
> variable "last" ahead to the send completion time upon transmission and
> adding wait when the next dequeue request comes before the send
> completion time of the previous packet.

Yeah, this improves (a lot) the accuracy of the software mode when
dealing with larger packets:

| Idleslope (packet size) | Old (bps) | New (bps) |
|-------------------------+-----------+-----------|
| 500mbps (100bytes)      | 528M      | 492M      |
| 500mbps (1500bytes)     | 622M      | 499M      |
| 1mbps (100bytes)        | 1007k     | 1006k     |
| 1mbps (1500bytes)       | 1010k     | 1010k     |

(Sorry for the mess of units)

So, when the comments from Jakub are addressed:

Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>


Cheers,
-- 
Vinicius