netdev - Re: [PATCH] net: phy: dp83867: w/a for fld detect threshold bootstrapping issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Mar 2020 22:36:32 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     David Miller <davem@...emloft.net>
CC:     <andrew@...n.ch>, <f.fainelli@...il.com>, <dmurphy@...com>,
        <hkallweit1@...il.com>, <netdev@...r.kernel.org>, <nsekhar@...com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: phy: dp83867: w/a for fld detect threshold
 bootstrapping issue



On 22/03/2020 05:10, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@...com>
> Date: Tue, 17 Mar 2020 20:04:54 +0200
> 
>> When the DP83867 PHY is strapped to enable Fast Link Drop (FLD) feature
>> STRAP_STS2.STRAP_ FLD (reg 0x006F bit 10), the Energy Lost Threshold for
>> FLD Energy Lost Mode FLD_THR_CFG.ENERGY_LOST_FLD_THR (reg 0x002e bits 2:0)
>> will be defaulted to 0x2. This may cause the phy link to be unstable. The
>> new DP83867 DM recommends to always restore ENERGY_LOST_FLD_THR to 0x1.
>>
>> Hence, restore default value of FLD_THR_CFG.ENERGY_LOST_FLD_THR to 0x1 when
>> FLD is enabled by bootstrapping as recommended by DM.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> 
> Applied, thank you.
> 

Thank you.

> Let me know if I should queue this up for -stable.
> 

yes, please, as there are real link instability issues were observed without this change.


-- 
Best regards,
grygorii