netdev - Re: [PATCH] net: phy: at803x: select correct page on initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200323211150.GA12621@lunn.ch>
Date:   Mon, 23 Mar 2020 22:11:50 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     David Bauer <mail@...id-bauer.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: at803x: select correct page on initialization

On Mon, Mar 23, 2020 at 10:08:49PM +0100, David Bauer wrote:
> Hello Andrew,
> 
> On 3/23/20 5:53 PM, Andrew Lunn wrote:
> > You might want to look at phy_read_paged(), phy_write_paged(), etc,
> > depending on your needs. There can be locking issues, which these
> > functions address.
> 
> Thanks for the hint, i was not aware of these methods. I see how they can handle
> e.g. the page-switching logic in phy_read_paged.
> 
> However i still need to select the copper page on config initialization manually,
> as genphy_update_link is not page aware or am i missing something here?

Hi David

Yes, for that initial setup, you need to directly write to the
register. But at803x_aneg_done() should use these helpers.

	  Andrew