netdev - Re: [PATCH bpf-next v5 0/2] Refactor perf_event sample user program with libbpf bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Mar 2020 22:38:57 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     "Daniel T. Lee" <danieltimlee@...il.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 0/2] Refactor perf_event sample user program
 with libbpf bpf_link

On 3/21/20 11:04 AM, Daniel T. Lee wrote:
> Currently, some samples are using ioctl for enabling perf_event and
> attaching BPF programs to this event. However, the bpf_program__attach
> of libbpf(using bpf_link) is much more intuitive than the previous
> method using ioctl.
> 
> bpf_program__attach_perf_event manages the enable of perf_event and
> attach of BPF programs to it, so there's no neeed to do this
> directly with ioctl.
> 
> In addition, bpf_link provides consistency in the use of API because it
> allows disable (detach, destroy) for multiple events to be treated as
> one bpf_link__destroy.
> 
> To refactor samples with using this libbpf API, the bpf_load in the
> samples were removed and migrated to libbbpf. Because read_trace_pipe
> is used in bpf_load, multiple samples cannot be migrated to libbpf,
> this function was moved to trace_helpers.

Applied, thanks!