netdev - RE: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cc301d6015c$7e756490$7b602db0$@codeaurora.org>
Date:   Mon, 23 Mar 2020 16:46:17 -0500
From:   "Brian Cain" <bcain@...eaurora.org>
To:     "'Thomas Gleixner'" <tglx@...utronix.de>,
        "'LKML'" <linux-kernel@...r.kernel.org>
Cc:     "'Peter Zijlstra'" <peterz@...radead.org>,
        "'Ingo Molnar'" <mingo@...nel.org>,
        "'Sebastian Siewior'" <bigeasy@...utronix.de>,
        "'Linus Torvalds'" <torvalds@...ux-foundation.org>,
        "'Joel Fernandes'" <joel@...lfernandes.org>,
        "'Oleg Nesterov'" <oleg@...hat.com>,
        "'Davidlohr Bueso'" <dave@...olabs.net>,
        "'kbuild test robot'" <lkp@...el.com>,
        <linux-hexagon@...r.kernel.org>,
        "'Logan Gunthorpe'" <logang@...tatee.com>,
        "'Bjorn Helgaas'" <bhelgaas@...gle.com>,
        "'Kurt Schwemmer'" <kurt.schwemmer@...rosemi.com>,
        <linux-pci@...r.kernel.org>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Felipe Balbi'" <balbi@...nel.org>, <linux-usb@...r.kernel.org>,
        "'Kalle Valo'" <kvalo@...eaurora.org>,
        "'David S. Miller'" <davem@...emloft.net>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        "'Darren Hart'" <dvhart@...radead.org>,
        "'Andy Shevchenko'" <andy@...radead.org>,
        <platform-driver-x86@...r.kernel.org>,
        "'Zhang Rui'" <rui.zhang@...el.com>,
        "'Rafael J. Wysocki'" <rafael.j.wysocki@...el.com>,
        <linux-pm@...r.kernel.org>, "'Len Brown'" <lenb@...nel.org>,
        <linux-acpi@...r.kernel.org>, "'Nick Hu'" <nickhu@...estech.com>,
        "'Greentime Hu'" <green.hu@...il.com>,
        "'Vincent Chen'" <deanbo422@...il.com>,
        "'Guo Ren'" <guoren@...nel.org>, <linux-csky@...r.kernel.org>,
        "'Tony Luck'" <tony.luck@...el.com>,
        "'Fenghua Yu'" <fenghua.yu@...el.com>,
        <linux-ia64@...r.kernel.org>, "'Michal Simek'" <monstr@...str.eu>,
        "'Michael Ellerman'" <mpe@...erman.id.au>,
        "'Arnd Bergmann'" <arnd@...db.de>,
        "'Geoff Levand'" <geoff@...radead.org>,
        <linuxppc-dev@...ts.ozlabs.org>,
        "'Paul E . McKenney'" <paulmck@...nel.org>,
        "'Jonathan Corbet'" <corbet@....net>,
        "'Randy Dunlap'" <rdunlap@...radead.org>,
        "'Davidlohr Bueso'" <dbueso@...e.de>
Subject: RE: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h

> -----Original Message-----
> From: Thomas Gleixner <tglx@...utronix.de>
...
> Subject: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h
> 
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> 
> The defconfig compiles without linux/mm.h. With mm.h included the include
> chain leands to:
> |   CC      kernel/locking/percpu-rwsem.o
> | In file included from include/linux/huge_mm.h:8,
> |                  from include/linux/mm.h:567,
> |                  from arch/hexagon/include/asm/uaccess.h:,
> |                  from include/linux/uaccess.h:11,
> |                  from include/linux/sched/task.h:11,
> |                  from include/linux/sched/signal.h:9,
> |                  from include/linux/rcuwait.h:6,
> |                  from include/linux/percpu-rwsem.h:8,
> |                  from kernel/locking/percpu-rwsem.c:6:
> | include/linux/fs.h:1422:29: error: array type has incomplete element type
> 'struct percpu_rw_semaphore'
> |  1422 |  struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
> 
> once rcuwait.h includes linux/sched/signal.h.
> 
> Remove the linux/mm.h include.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Brian Cain <bcain@...eaurora.org>
> Cc: linux-hexagon@...r.kernel.org
> ---
> V3: New patch
> ---
>  arch/hexagon/include/asm/uaccess.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/hexagon/include/asm/uaccess.h
> b/arch/hexagon/include/asm/uaccess.h
> index 00cb38faad0c4..c1019a736ff13 100644
> --- a/arch/hexagon/include/asm/uaccess.h
> +++ b/arch/hexagon/include/asm/uaccess.h
> @@ -10,7 +10,6 @@
>  /*
>   * User space memory access functions
>   */
> -#include <linux/mm.h>
>  #include <asm/sections.h>
> 
>  /*
> --
> 2.26.0.rc2
> 

Acked-by: Brian Cain <bcain@...eaurora.org>