netdev - RE: [PATCH net-next 1/4] net: dsa: sja1105: unconditionally set DESTMETA and SRCMETA in AVB table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Mar 2020 07:39:06 +0000
From:   Christian Herber <christian.herber@....com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "richardcochran@...il.com" <richardcochran@...il.com>
CC:     "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>, "Y.b. Lu" <yangbo.lu@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 1/4] net: dsa: sja1105: unconditionally set
 DESTMETA and SRCMETA in AVB table

>+static int sja1105_init_avb_params(struct sja1105_private *priv)
>+{
>+       struct sja1105_avb_params_entry *avb;
>+       struct sja1105_table *table;
>+
>+       table = &priv->static_config.tables[BLK_IDX_AVB_PARAMS];
>+
>+       /* Discard previous AVB Parameters Table */
>+       if (table->entry_count) {
>+               kfree(table->entries);
>+               table->entry_count = 0;
>+       }
>+
>+       table->entries = kcalloc(SJA1105_MAX_AVB_PARAMS_COUNT,
>+                                table->ops->unpacked_entry_size, GFP_KERNEL);
>+       if (!table->entries)
>+               return -ENOMEM;
>+
>+       table->entry_count = SJA1105_MAX_AVB_PARAMS_COUNT;
>+
>+       avb = table->entries;
>+
>+       /* Configure the MAC addresses for meta frames */
>+       avb->destmeta = SJA1105_META_DMAC;
>+       avb->srcmeta  = SJA1105_META_SMAC;
>+
>+       return 0;
>+}
>+
 
Would it be possible to use the MAC address of the connected eth as destination? This is nicer also when going over multiple cascaded switches.

Christian