netdev - Re: [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hrB6JUcM87Lv_V-gMdyVOCncJ9yhRmtVGgWt6eB0MhSow@mail.gmail.com>
Date:   Tue, 24 Mar 2020 10:55:55 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Voon Weifeng <weifeng.voon@...el.com>,
        "Dmitry V. Levin" <ldv@...linux.org>
Subject: Re: [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_*
 definitions

Hi Eugene,

On Tue, 24 Mar 2020 at 06:19, Eugene Syromiatnikov <esyr@...hat.com> wrote:
>
> BIT() macro definition is internal to the Linux kernel and is not
> to be used in UAPI headers; replace its usage with the _BITUL() macro
> that is already used elsewhere in the header.
>
> Cc: <stable@...r.kernel.org> # v5.4+
> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> ---

I see this mirrors what was done in commit

commit 9903c8dc734265689d5770ff28c84a7228fe5890
Author: Vedang Patel <vedang.patel@...el.com>
Date:   Tue Jun 25 15:07:13 2019 -0700

    etf: Don't use BIT() in UAPI headers.

    The BIT() macro isn't exported as part of the UAPI interface. So, the
    compile-test to ensure they are self contained fails. So, use _BITUL()
    instead.

    Signed-off-by: Vedang Patel <vedang.patel@...el.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

so

Acked-by: Vladimir Oltean <vladimir.oltean@....com>

>  include/uapi/linux/pkt_sched.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
> index bbe791b..0e43f67 100644
> --- a/include/uapi/linux/pkt_sched.h
> +++ b/include/uapi/linux/pkt_sched.h
> @@ -1197,8 +1197,8 @@ enum {
>   *       [TCA_TAPRIO_ATTR_SCHED_ENTRY_INTERVAL]
>   */
>
> -#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST     BIT(0)
> -#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD      BIT(1)
> +#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST     _BITUL(0)
> +#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD      _BITUL(1)
>
>  enum {
>         TCA_TAPRIO_ATTR_UNSPEC,
> --
> 2.1.4
>

Regards,
-Vladimir