netdev - Re: [v1,net-next 4/5] net: enetc: add hw tc hw offload features for PSPF capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Mar 2020 19:18:22 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Po Liu <Po.Liu@....com>
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [v1,net-next  4/5] net: enetc: add hw tc hw offload features for
 PSPF capability

Hi Po,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20200323]
[cannot apply to linux/master linus/master sparc-next/master ipvs/master v5.6-rc7 v5.6-rc6 v5.6-rc5 v5.6-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Po-Liu/Introduce-a-flow-gate-control-action-and-apply-IEEE/20200324-121156
base:    5149100c3aebe5e640d6ff68e0b5e5a7eb8638e0
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/freescale/enetc/enetc_ptp.c:8:
   drivers/net/ethernet/freescale/enetc/enetc.h: In function 'enetc_psfp_enable':
>> drivers/net/ethernet/freescale/enetc/enetc.h:345:9: warning: 'return' with a value, in function returning void [-Wreturn-type]
     345 |  return 0;
         |         ^
   drivers/net/ethernet/freescale/enetc/enetc.h:343:20: note: declared here
     343 | static inline void enetc_psfp_enable(struct enetc_hw *hw)
         |                    ^~~~~~~~~~~~~~~~~
   drivers/net/ethernet/freescale/enetc/enetc.h: In function 'enetc_psfp_disable':
   drivers/net/ethernet/freescale/enetc/enetc.h:350:9: warning: 'return' with a value, in function returning void [-Wreturn-type]
     350 |  return 0;
         |         ^
   drivers/net/ethernet/freescale/enetc/enetc.h:348:20: note: declared here
     348 | static inline void enetc_psfp_disable(struct enetc_hw *hw)
         |                    ^~~~~~~~~~~~~~~~~~

vim +/return +345 drivers/net/ethernet/freescale/enetc/enetc.h

   328	
   329	static inline void enetc_psfp_disable(struct enetc_hw *hw)
   330	{
   331		enetc_wr(hw, ENETC_PPSFPMR, enetc_rd(hw, ENETC_PPSFPMR)
   332			 & ~ENETC_PPSFPMR_PSFPEN & ~ENETC_PPSFPMR_VS
   333			 & ~ENETC_PPSFPMR_PVC & ~ENETC_PPSFPMR_PVZC);
   334	}
   335	#else
   336	#define enetc_setup_tc_taprio(ndev, type_data) -EOPNOTSUPP
   337	#define enetc_sched_speed_set(ndev) (void)0
   338	#define enetc_setup_tc_cbs(ndev, type_data) -EOPNOTSUPP
   339	#define enetc_setup_tc_txtime(ndev, type_data) -EOPNOTSUPP
   340	#define enetc_get_max_cap(p)		\
   341		memset(&((p)->psfp_cap), 0, sizeof(struct psfp_cap))
   342	
   343	static inline void enetc_psfp_enable(struct enetc_hw *hw)
   344	{
 > 345		return 0;
   346	}
   347	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (48949 bytes)