netdev - Re: [PATCH 14/14] net: ks8851: Remove ks8851

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Mar 2020 15:12:17 +0100
From:   Marek Vasut <marex@...x.de>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH 14/14] net: ks8851: Remove ks8851_mll.c

On 3/24/20 3:08 PM, Lukas Wunner wrote:
> On Tue, Mar 24, 2020 at 12:43:03AM +0100, Marek Vasut wrote:
>> The ks8851_mll.c is replaced by ks8851_par.c, which is using common code
>> from ks8851.c, just like ks8851_spi.c . Remove this old ad-hoc driver.
> 
> Hm, have you checked whether ks8851_mll.c contains functionality
> that is currently missing in ks8851.c and which is worth salvaging?

There's 8bit and 32bit bus support. The former was broken and the later
I don't think is even supported by any chip in existence.

btw is there something which has the KS8851 SPI option, so I can test
that one too ?