netdev - Re: [PATCH v2 net-next] tcp/dccp: Move initialisation of refcounted into if block.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200324.162320.60114994463504898.davem@davemloft.net>
Date:   Tue, 24 Mar 2020 16:23:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuniyu@...zon.co.jp
Cc:     kuba@...nel.org, edumazet@...gle.com, gerrit@....abdn.ac.uk,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        dccp@...r.kernel.org, netdev@...r.kernel.org, kuni1840@...il.com,
        osa-contribution-log@...zon.com
Subject: Re: [PATCH v2 net-next] tcp/dccp: Move initialisation of
 refcounted into if block.

From: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Date: Tue, 24 Mar 2020 20:33:31 +0900

> The refcounted seems to be initialised at most three times, but the
> complier can optimize that and the refcounted is initialised only at once.
> 
>   - __inet_lookup_skb() sets it true.
>   - skb_steal_sock() is false and __inet_lookup() sets it true.
>   - __inet_lookup_established() is false and __inet_lookup() sets it false.
> 
> The code is bit confusing, so this patch makes it more readable so that no
> one doubt about the complier optimization.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>

I don't think this improves the code readability nor code generation, it's
just noise changes and will make backporting more difficult.

I'm not applying this sorry.

In the future, I am going to apply a large threshold as to whether
changes like this are reasonable and appropriate.  Please keep that
in mind for your submissions.

Thank you.