netdev - Re: [PATCH net-next v2 0/3] net: phy: add and use phy_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200323.211004.657670862190579071.davem@davemloft.net>
Date:   Mon, 23 Mar 2020 21:10:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/3] net: phy: add and use
 phy_check_downshift

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 20 Mar 2020 17:50:12 +0100

> So far PHY drivers have to check whether a downshift occurred to be
> able to notify the user. To make life of drivers authors a little bit
> easier move the downshift notification to phylib. phy_check_downshift()
> compares the highest mutually advertised speed with the actual value
> of phydev->speed (typically read by the PHY driver from a
> vendor-specific register) to detect a downshift.
> 
> v2: Add downshift hint to phy_print_status().

This honestly looks good to me, series applied, thanks Heiner.