netdev - Re: [PATCH net-next 01/15] devlink: Add packet trap policers support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200325094639.GB1332836@splinter>
Date:   Wed, 25 Mar 2020 11:46:39 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 01/15] devlink: Add packet trap policers support

On Tue, Mar 24, 2020 at 08:37:23PM -0700, Jakub Kicinski wrote:
> On Tue, 24 Mar 2020 21:32:36 +0200 Ido Schimmel wrote:
> >  static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = {
> 
> Hm. looks like devlink doesn't have .strict_start_type set, yet.
> Should we set it?

Good point. Will add.

> 
> >  	[DEVLINK_ATTR_BUS_NAME] = { .type = NLA_NUL_STRING },
> >  	[DEVLINK_ATTR_DEV_NAME] = { .type = NLA_NUL_STRING },
> > @@ -6064,6 +6309,9 @@ static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = {
> >  	[DEVLINK_ATTR_NETNS_PID] = { .type = NLA_U32 },
> >  	[DEVLINK_ATTR_NETNS_FD] = { .type = NLA_U32 },
> >  	[DEVLINK_ATTR_NETNS_ID] = { .type = NLA_U32 },
> > +	[DEVLINK_ATTR_TRAP_POLICER_ID] = { .type = NLA_U32 },
> > +	[DEVLINK_ATTR_TRAP_POLICER_RATE] = { .type = NLA_U64 },
> > +	[DEVLINK_ATTR_TRAP_POLICER_BURST] = { .type = NLA_U64 },
> >  };