netdev - Re: [PATCH net-next] netfilter: flowtable: Fix accessing null dst entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR05MB5096B0ACD2A2B4A7E1B75935CFCE0@AM6PR05MB5096.eurprd05.prod.outlook.com>
Date:   Wed, 25 Mar 2020 11:52:09 +0000
From:   Paul Blakey <paulb@...lanox.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
CC:     Oz Shlomo <ozsh@...lanox.com>, Majd Dibbiny <majd@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH net-next] netfilter: flowtable: Fix accessing null dst
 entry

pending patch seems fine.

________________________________________
From: Pablo Neira Ayuso <pablo@...filter.org>
Sent: Wednesday, March 25, 2020 12:55 PM
To: Paul Blakey
Cc: Oz Shlomo; Majd Dibbiny; Roi Dayan; netdev@...r.kernel.org; Saeed Mahameed; netfilter-devel@...r.kernel.org
Subject: Re: [PATCH net-next] netfilter: flowtable: Fix accessing null dst entry

On Wed, Mar 25, 2020 at 12:53:28PM +0200, Paul Blakey wrote:
> Unlink nft flow table flows, flows from act_ct tables don't have route,
> and so don't have a dst_entry. nf_flow_rule_match() tries to deref
> this null dst_entry regardless.
>
> Fix that by checking for dst entry exists, and if not, skip
> tunnel match.

This is fixed in nf-next:

https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/

I'll get this merged into net-next asap.