netdev - Re: [PATCH net] selftests/net/forwarding: define libs as TEST_PROGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200325133700.GE2159@dhcp-12-139.nay.redhat.com>
Date:   Wed, 25 Mar 2020 21:37:00 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     netdev@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        linux-kselftest@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] selftests/net/forwarding: define libs as
 TEST_PROGS_EXTENDED

On Wed, Mar 25, 2020 at 12:26:33PM +0200, Vadym Kochan wrote:
> Hi Hangbin Liu,
> 
> On Wed, Mar 25, 2020 at 04:41:01PM +0800, Hangbin Liu wrote:
> > The lib files should not be defined as TEST_PROGS, or we will run them
> > in run_kselftest.sh.
> > 
> > Also remove ethtool_lib.sh exec permission.
> > 
> > Fixes: 81573b18f26d ("selftests/net/forwarding: add Makefile to install tests")
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> Thanks for fixing it, sorry for my mistake. Actually forwarding tests
> requires interfaces list as runtime parameter or if it is defined in 
> forwarding.config file, so may be they should not run by run_kselftest
> at all and only added via TEST_PROGS_EXTENDED ?

Before I run forwarding test, I usually do
`cp forwarding.config.sample forwarding.config` first. I think the runner
should aware of this.

Thanks
Hangbin