netdev - Re: [PATCH net-next] net: use indirect call wrappers for skb_copy_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e385f0c1edca94a882bdadf46f4ddb97d59a64a.camel@redhat.com>
Date:   Wed, 25 Mar 2020 17:24:18 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: use indirect call wrappers for
 skb_copy_datagram_iter()

On Wed, 2020-03-25 at 09:07 -0700, Eric Dumazet wrote:
> 
> On 3/25/20 9:00 AM, Paolo Abeni wrote:
> 
> > For the record, I have 2 others item on my list, I hope to have time to
> > process some day: the ingress dst->input and the default ->enqueue  and
> > ->dequeue
> 
> What is the default ->enqueue() and ->dequeue() ?

The idea is (or should I say 'was' ?!?) to tie it to NET_SCH_DEFAULT,
so it depends on your config...

> For us, this is FQ.
> 
> (Even if we do not select NET_SCH_DEFAULT and leave pfifo_fast as the 'default' qdisc)

... this one will see no benefit.

Just out of sheer curiosity, why don't you set NET_SCH_DEFAULT?

Thanks,

Paolo