netdev - RE: [EXT] Re: [PATCH net-next 1/3] qed: Replace wq_active Boolean with an atomic QED_SLOWPATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR18MB3150183ACB5D37C3D8537212D0CE0@MN2PR18MB3150.namprd18.prod.outlook.com>
Date:   Wed, 25 Mar 2020 20:35:15 +0000
From:   Yuval Basson <ybason@...vell.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Denis Bolotin <dbolotin@...vell.com>
Subject: RE: [EXT] Re: [PATCH net-next 1/3] qed: Replace wq_active Boolean
 with an atomic QED_SLOWPATH_ACTIVE flag



> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Wednesday, March 25, 2020 1:36 AM
> To: Yuval Basson <ybason@...vell.com>
> Cc: netdev@...r.kernel.org; Denis Bolotin <dbolotin@...vell.com>
> Subject: [EXT] Re: [PATCH net-next 1/3] qed: Replace wq_active Boolean
> with an atomic QED_SLOWPATH_ACTIVE flag
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Yuval Basson <ybason@...vell.com>
> Date: Tue, 24 Mar 2020 16:13:46 +0200
> 
> > The atomic opertaion might prevent a potential race condition.
> >
> > Signed-off-by: Yuval Basson <ybason@...vell.com>
> > Signed-off-by: Denis Bolotin <dbolotin@...vell.com>
> 
> There is no basis in fact behind this change.
> > thanks for the comment, indeed it seems the only patch required to solve the race is the third one
>> Sending a v2 with just the third patch.
> Either explain clearly and precisely what race is fixed by this change or
> remove this change.
> 
> Thank you.