netdev - Re: [PATCH v2 net-next 06/10] net: dsa: b53: Add MTU configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b5e3b75-bf51-3341-824f-f47feb556f67@gmail.com>
Date:   Wed, 25 Mar 2020 16:21:55 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, andrew@...n.ch,
        vivien.didelot@...il.com, davem@...emloft.net,
        jakub.kicinski@...ronome.com
Cc:     murali.policharla@...adcom.com, stephen@...workplumber.org,
        jiri@...nulli.us, idosch@...sch.org, kuba@...nel.org,
        nikolay@...ulusnetworks.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 06/10] net: dsa: b53: Add MTU configuration
 support



On 3/25/2020 8:22 AM, Vladimir Oltean wrote:
> From: Murali Krishna Policharla <murali.policharla@...adcom.com>
> 
> Add b53_change_mtu API to configure mtu settings in B53 switch. Enable
> jumbo frame support if configured mtu size is for jumbo frame. Also
> configure BCM583XX devices to send and receive jumbo frames when ports
> are configured with 10/100 Mbps speed.
> 
> Signed-off-by: Murali Krishna Policharla <murali.policharla@...adcom.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

[snip]

> @@ -658,6 +659,14 @@ static void b53_enable_cpu_port(struct b53_device *dev, int port)
>  	b53_brcm_hdr_setup(dev->ds, port);
>  
>  	b53_br_egress_floods(dev->ds, port, true, true);
> +
> +	b53_read32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, &port_mask);
> +
> +	if (dev->chip_id == BCM583XX_DEVICE_ID)
> +		port_mask |= JPM_10_100_JUMBO_EN;
> +
> +	port_mask |= BIT(port);
> +	b53_write32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, port_mask);

This should eventually be brought into b53_set_jumbo() where we already
have existing logic to configure whether to accept jumbo frames and for
10/100M ports, too, not strictly necessary for now though:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian