| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <88deb8bb-718c-f8ce-885e-dbc122201f16@baylibre.com>
Date: Thu, 26 Mar 2020 09:37:16 +0100
From: Neil Armstrong <narmstrong@...libre.com>
To: Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Brian Masney <masneyb@...tation.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Guillaume La Roque <glaroque@...libre.com>,
Hartmut Knaack <knaack.h@....de>,
Jonathan Cameron <jic23@...nel.org>,
Kevin Hilman <khilman@...libre.com>,
Lars-Peter Clausen <lars@...afoo.de>,
Lee Jones <lee.jones@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Linus Walleij <linus.walleij@...aro.org>,
Mark Brown <broonie@...nel.org>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Michael Hennerich <michael.hennerich@...log.com>,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Stephen Boyd <sboyd@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Zhang Rui <rui.zhang@...el.com>,
dri-devel@...ts.freedesktop.org, linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-iio@...r.kernel.org,
linux-media@...r.kernel.org, linux-pm@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties:
false'
On 25/03/2020 23:05, Rob Herring wrote:
> Setting 'additionalProperties: false' is frequently omitted, but is
> important in order to check that there aren't extra undocumented
> properties in a binding.
>
> Ideally, we'd just add this automatically and make this the default, but
> there's some cases where it doesn't work. For example, if a common
> schema is referenced, then properties in the common schema aren't part
> of what's considered for 'additionalProperties'. Also, sometimes there
> are bus specific properties such as 'spi-max-frequency' that go into
> bus child nodes, but aren't defined in the child node's schema.
>
> So let's stick with the json-schema defined default and add
> 'additionalProperties: false' where needed. This will be a continual
> review comment and game of wack-a-mole.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> .../devicetree/bindings/arm/altera/socfpga-clk-manager.yaml | 2 ++
> .../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml | 2 ++
> Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 2 ++
> Documentation/devicetree/bindings/arm/renesas,prr.yaml | 2 ++
> .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 2 ++
> Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 ++
> .../bindings/arm/samsung/samsung-secure-firmware.yaml | 2 ++
> .../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 2 ++
> Documentation/devicetree/bindings/clock/fsl,plldig.yaml | 2 ++
> Documentation/devicetree/bindings/clock/imx8mn-clock.yaml | 2 ++
> Documentation/devicetree/bindings/clock/imx8mp-clock.yaml | 2 ++
> Documentation/devicetree/bindings/clock/milbeaut-clock.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-msm8996.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-msm8998.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-qcs404.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-sc7180.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-sm8150.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,mmcc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,msm8998-gpucc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sc7180-dispcc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sc7180-videocc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sdm845-dispcc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,sdm845-gpucc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sdm845-videocc.yaml | 2 ++
> .../devicetree/bindings/display/amlogic,meson-vpu.yaml | 2 ++
> .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml | 2 ++
> Documentation/devicetree/bindings/dsp/fsl,dsp.yaml | 2 ++
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++
> .../firmware/intel,ixp4xx-network-processing-engine.yaml | 3 +++
> .../devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml | 2 ++
> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++
> Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/samsung-rotator.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml | 2 ++
> Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 2 ++
> Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml | 2 ++
> Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml | 2 ++
> Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml | 2 ++
> .../devicetree/bindings/iio/adc/microchip,mcp3911.yaml | 2 ++
> .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 ++
> .../devicetree/bindings/iio/chemical/plantower,pms7003.yaml | 2 ++
> .../devicetree/bindings/iio/chemical/sensirion,sps30.yaml | 2 ++
> Documentation/devicetree/bindings/iio/dac/lltc,ltc1660.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/adux1020.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/bh1750.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/isl29018.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/noa1305.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/tsl2583.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/tsl2772.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/veml6030.yaml | 2 ++
> .../devicetree/bindings/iio/pressure/asc,dlhl60d.yaml | 2 ++
> Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 2 ++
> .../devicetree/bindings/iio/proximity/devantech-srf04.yaml | 2 ++
> .../devicetree/bindings/iio/proximity/parallax-ping.yaml | 2 ++
> .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 2 ++
> Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 2 ++
> Documentation/devicetree/bindings/input/max77650-onkey.yaml | 3 +++
> .../bindings/interrupt-controller/intel,ixp4xx-interrupt.yaml | 2 ++
> Documentation/devicetree/bindings/iommu/samsung,sysmmu.yaml | 2 ++
> Documentation/devicetree/bindings/leds/leds-max77650.yaml | 3 +++
> Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml | 3 +++
> .../devicetree/bindings/mailbox/amlogic,meson-gxbb-mhu.yaml | 2 ++
> Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml | 2 ++
> .../devicetree/bindings/media/amlogic,meson-gx-ao-cec.yaml | 2 ++
> Documentation/devicetree/bindings/media/renesas,ceu.yaml | 2 ++
> Documentation/devicetree/bindings/mfd/max77650.yaml | 2 ++
> Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 2 ++
> .../bindings/misc/intel,ixp4xx-ahb-queue-manager.yaml | 2 ++
> Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml | 2 ++
> .../devicetree/bindings/phy/allwinner,sun50i-h6-usb3-phy.yaml | 2 ++
> .../bindings/phy/amlogic,meson-g12a-usb3-pcie-phy.yaml | 2 ++
> Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml | 2 ++
> .../devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 2 ++
> Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml | 2 ++
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 ++
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 ++
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 ++
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 2 ++
> .../devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml | 2 ++
> .../devicetree/bindings/power/reset/syscon-poweroff.yaml | 2 ++
> .../devicetree/bindings/power/reset/syscon-reboot.yaml | 2 ++
> .../devicetree/bindings/power/supply/max77650-charger.yaml | 3 +++
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 2 ++
> .../devicetree/bindings/regulator/max77650-regulator.yaml | 3 +++
> .../devicetree/bindings/reset/amlogic,meson-reset.yaml | 2 ++
> .../bindings/reset/brcm,bcm7216-pcie-sata-rescal.yaml | 2 ++
> Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 2 ++
> Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml | 2 ++
> Documentation/devicetree/bindings/rtc/renesas,sh-rtc.yaml | 2 ++
> Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml | 2 ++
> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++
> .../devicetree/bindings/soc/amlogic/amlogic,canvas.yaml | 2 ++
> Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 ++
> Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 2 ++
> Documentation/devicetree/bindings/sound/renesas,fsi.yaml | 2 ++
> Documentation/devicetree/bindings/sound/samsung,odroid.yaml | 2 ++
> Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 2 ++
> Documentation/devicetree/bindings/sram/qcom,ocmem.yaml | 2 ++
> Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 2 ++
> Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 2 ++
> .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 ++
> Documentation/devicetree/bindings/timer/arm,global_timer.yaml | 2 ++
> .../devicetree/bindings/timer/intel,ixp4xx-timer.yaml | 2 ++
> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 117 files changed, 240 insertions(+)
>
For:
.../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml | 2 ++
.../devicetree/bindings/display/amlogic,meson-vpu.yaml | 2 ++
.../devicetree/bindings/mailbox/amlogic,meson-gxbb-mhu.yaml | 2 ++
.../devicetree/bindings/media/amlogic,meson-gx-ao-cec.yaml | 2 ++
Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml | 2 ++
.../bindings/phy/amlogic,meson-g12a-usb3-pcie-phy.yaml | 2 ++
.../devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml | 2 ++
.../devicetree/bindings/reset/amlogic,meson-reset.yaml | 2 ++
Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 2 ++
.../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++
.../devicetree/bindings/soc/amlogic/amlogic,canvas.yaml | 2 ++
Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 2 ++
Reviewed-by: Neil Armstrong <narmstrong@...libre.com>
Powered by blists - more mailing lists