netdev - Re: [PATCH v2 net-next 3/7] devlink: Add macro for "hw.addr" to info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 Mar 2020 21:33:20 +0530
From:   Vasundhara Volam <vasundhara-v.volam@...adcom.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH v2 net-next 3/7] devlink: Add macro for "hw.addr" to
 info_get cb.

On Thu, Mar 26, 2020 at 9:24 PM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Thu, Mar 26, 2020 at 12:02:43PM CET, vasundhara-v.volam@...adcom.com wrote:
> >On Thu, Mar 26, 2020 at 2:56 PM Jiri Pirko <jiri@...nulli.us> wrote:
> >>
> >> Thu, Mar 26, 2020 at 07:27:00AM CET, vasundhara-v.volam@...adcom.com wrote:
> >> >Add definition and documentation for the new generic info "hw.addr".
> >> >"hw.addr" displays the hardware address of the interface.
> >> >
> >> >Cc: Jiri Pirko <jiri@...lanox.com>
> >> >Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> >> >Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> >> >---
> >> > Documentation/networking/devlink/devlink-info.rst | 5 +++++
> >> > include/net/devlink.h                             | 3 +++
> >> > 2 files changed, 8 insertions(+)
> >> >
> >> >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
> >> >index 650e2c0e3..56d13c5 100644
> >> >--- a/Documentation/networking/devlink/devlink-info.rst
> >> >+++ b/Documentation/networking/devlink/devlink-info.rst
> >> >@@ -144,6 +144,11 @@ board.manufacture
> >> >
> >> > An identifier of the company or the facility which produced the part.
> >> >
> >> >+hw.addr
> >> >+-------
> >> >+
> >> >+Hardware address of the interface.
> >> >+
> >> > fw
> >> > --
> >> >
> >> >diff --git a/include/net/devlink.h b/include/net/devlink.h
> >> >index d51482f..c9383f4 100644
> >> >--- a/include/net/devlink.h
> >> >+++ b/include/net/devlink.h
> >> >@@ -476,6 +476,9 @@ enum devlink_param_generic_id {
> >> > /* Revision of asic design */
> >> > #define DEVLINK_INFO_VERSION_GENERIC_ASIC_REV "asic.rev"
> >> >
> >> >+/* Hardware address */
> >> >+#define DEVLINK_INFO_VERSION_GENERIC_HW_ADDR  "hw.addr"
> >>
> >> Wait a second. Is this a MAC. I don't understand why MAC would be here.
> >Yes, this is MAC address. Since, most of the information is displayed
> >via info_get
> >as one place. Would like to display MAC address as well under info_get.
>
> No, I don't want to display mac here. It is a netdevice attribute. Leave
> it there.
>
Yes, realised it and sent a v3 patchset already, removing the MAC
address. Thanks.
>
> >
> >Thanks,
> >Vasundhara
> >
> >
> >> If not MAC, what is exactly this address about?
> >>
> >>
> >> >+
> >> > /* Overall FW version */
> >> > #define DEVLINK_INFO_VERSION_GENERIC_FW               "fw"
> >> > /* Overall FW interface specification version */
> >> >--
> >> >1.8.3.1
> >> >