netdev - Re: [net-next] tipc: Add a missing case of TIPC_DIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200326.112117.296057933553903521.davem@davemloft.net>
Date:   Thu, 26 Mar 2020 11:21:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hoang.h.le@...tech.com.au
Cc:     netdev@...r.kernel.org, ying.xue@...driver.com, maloy@...jonn.com,
        jmaloy@...hat.com, tuong.t.lien@...tech.com.au
Subject: Re: [net-next] tipc: Add a missing case of TIPC_DIRECT_MSG type

From: Hoang Le <hoang.h.le@...tech.com.au>
Date: Thu, 26 Mar 2020 09:50:29 +0700

> In the commit f73b12812a3d
> ("tipc: improve throughput between nodes in netns"), we're missing a check
> to handle TIPC_DIRECT_MSG type, it's still using old sending mechanism for
> this message type. So, throughput improvement is not significant as
> expected.
> 
> Besides that, when sending a large message with that type, we're also
> handle wrong receiving queue, it should be enqueued in socket receiving
> instead of multicast messages.
> 
> Fix this by adding the missing case for TIPC_DIRECT_MSG.
> 
> Fixes: f73b12812a3d ("tipc: improve throughput between nodes in netns")
> Reported-by: Tuong Lien <tuong.t.lien@...tech.com.au>
> Signed-off-by: Hoang Le <hoang.h.le@...tech.com.au>
> Acked-by: Jon Maloy <jmaloy@...hat.com>

Applied to net-next, thank you.