netdev - Re: [net-next v2 11/11] ice: add a devlink region for dumping NVM contents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326211132.GB11304@nanopsycho.orion>
Date:   Thu, 26 Mar 2020 22:11:32 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [net-next v2 11/11] ice: add a devlink region for dumping NVM
 contents

Thu, Mar 26, 2020 at 05:23:39PM CET, jacob.e.keller@...el.com wrote:
>
>
>On 3/26/2020 2:02 AM, Jiri Pirko wrote:
>> Thu, Mar 26, 2020 at 04:51:57AM CET, jacob.e.keller@...el.com wrote:
>>> +
>>> +Regions
>>> +=======
>>> +
>>> +The ``ice`` driver enables access to the contents of the Non Volatile Memory
>>> +flash chip via the ``nvm-flash`` region.
>>> +
>>> +Users can request an immediate capture of a snapshot via the
>>> +``DEVLINK_CMD_REGION_NEW``
>>> +
>>> +.. code:: shell
>>> +
>>> +    $ devlink region new pci/0000:01:00.0/nvm-flash snapshot 1
>>> +    $ devlink region dump pci/0000:01:00.0/nvm-flash snapshot 1
>>> +
>>> +    $ devlink region dump pci/0000:01:00.0/nvm-flash snapshot 1
>>> +    0000000000000000 0014 95dc 0014 9514 0035 1670 0034 db30
>>> +    0000000000000010 0000 0000 ffff ff04 0029 8c00 0028 8cc8
>>> +    0000000000000020 0016 0bb8 0016 1720 0000 0000 c00f 3ffc
>>> +    0000000000000030 bada cce5 bada cce5 bada cce5 bada cce5
>>> +
>>> +    $ devlink region read pci/0000:01:00.0/nvm-flash snapshot 1 address 0
>>> +        length 16
>> 
>> Don't wrap the cmdline.
>
>The devlink-region.rst file wrapped it like this..

That is quite odd. I don't think it is correct.