netdev - Re: [PATCH net-next v3 06/11] devlink: extract snapshot id allocation to helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9c54aa9-0050-4d4f-cbb3-78ce540dcc81@intel.com>
Date:   Thu, 26 Mar 2020 14:37:47 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v3 06/11] devlink: extract snapshot id allocation
 to helper function



On 3/26/2020 2:15 PM, Jiri Pirko wrote:
> Thu, Mar 26, 2020 at 07:37:13PM CET, jacob.e.keller@...el.com wrote:
>> A future change is going to implement a new devlink command to request
>> a snapshot on demand. As part of this, the logic for handling the
>> snapshot ids will be refactored. To simplify the snapshot id allocation
>> function, move it to a separate function prefixed by `__`. This helper
>> function will assume the lock is held.
>>
>> While no other callers will exist, it simplifies refactoring the logic
>> because there is no need to complicate the function with gotos to handle
>> unlocking on failure.
>>
>> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> 
> For the 3rd time. I'm not sure why you don't took this :/
> 

Missed it while going over all the emails to take in review.